Jonas Ådahl [Tue, 7 Jan 2020 16:13:22 +0000 (17:13 +0100)]
wayland/surface: Add per surface configuration event queues
Add event queues specifically for surface configuration events
(xdg_surface.configure, xdg_toplevel.configure, xdg_popup.configure etc)
so that a configuration can be completed without having side effects on
other surfaces. This will be used to synchronously configure specific
GdkSurfaces, as is needed by the Gtk layout mechanisms.
Jonas Ådahl [Tue, 10 Dec 2019 18:23:17 +0000 (19:23 +0100)]
gdk/wayland/surface: Use dedicated bool for frame callback freezing
The freezing is conditioned on various state, so lets make the thawing a
bit more robust. Without this there was a risk that we'd thaw too many
times if there was a frame callback requested while the conditions for
the freezing were not met.
Jonas Ådahl [Wed, 24 Jul 2019 16:44:32 +0000 (18:44 +0200)]
wayland: Remove position method split
Position can only be done via gdk_surface_queue_relayout(); the legacy
way is no longer possible, so remove the legacy positioning code.
Jonas Ådahl [Mon, 22 Jul 2019 20:27:37 +0000 (22:27 +0200)]
gdk/surface: Use enum type for surface type
Jonas Ådahl [Mon, 22 Jul 2019 20:26:39 +0000 (22:26 +0200)]
tests/popover: Add check box for switching autohide prop
Jonas Ådahl [Wed, 24 Jul 2019 13:45:34 +0000 (15:45 +0200)]
popover: Unrealize when autohide prop changes
Changing the autohide property means the popover needs to be remapped.
Remapping may need user interaction, so lets just unrealize the popover
if the property changes, forcing the application to remap it should it
be shown again.
Emmanuele Bassi [Tue, 18 Feb 2020 10:58:06 +0000 (10:58 +0000)]
Merge branch 'dialog-headerbar-type-annotation' into 'master'
GtkDialog: Add `type Gtk.HeaderBar` annotation to headerbar getter return value
See merge request GNOME/gtk!1447
Sebastian Dröge [Tue, 18 Feb 2020 08:55:31 +0000 (10:55 +0200)]
GtkDialog: Add `type Gtk.HeaderBar` annotation to headerbar getter return value
Matthias Clasen [Mon, 17 Feb 2020 22:31:17 +0000 (22:31 +0000)]
Merge branch 'text-emoji-history' into 'master'
text: Treat Emoji insertion like clipboard
See merge request GNOME/gtk!1444
Matthias Clasen [Mon, 17 Feb 2020 20:05:09 +0000 (15:05 -0500)]
text: Treat Emoji insertion like clipboard
Enter the Emoji inseration in the undo history.
Also, stop stashing away the selection when we
pop up the Emoji chooser, and use the selection
as-is when we insert the Emoji.
Benjamin Otte [Sun, 16 Feb 2020 19:05:05 +0000 (20:05 +0100)]
widget: Fix namespacing problem
In Vala and JS at least, gtk_widget_get_css_name() and
gtk_widget_class_get_css_name() are resolved to
GtkWidget.get_css_name().
To avoid this problem, we rename the class version.
Benjamin Otte [Sun, 16 Feb 2020 18:57:45 +0000 (19:57 +0100)]
widget: Fix typos for css-clases property
Benjamin Otte [Sat, 15 Feb 2020 23:45:25 +0000 (23:45 +0000)]
Merge branch 'wip/otte/dnd' into 'master'
some DND fixes
See merge request GNOME/gtk!1440
Benjamin Otte [Sat, 15 Feb 2020 20:07:26 +0000 (21:07 +0100)]
tests: Do proper local DND
Just transfer GValues.
Benjamin Otte [Sat, 15 Feb 2020 20:04:57 +0000 (21:04 +0100)]
wayland: Use a magic mime type for local DND
Otherwise the compositor gets all confused when it's trying to make
drag happen but we know it's not going to happen.
After all, we exchange data behind its back, we just need to keep it
informed.
Benjamin Otte [Sat, 15 Feb 2020 19:26:55 +0000 (20:26 +0100)]
dragdest: Use format matching APIs
Benjamin Otte [Sat, 15 Feb 2020 19:02:44 +0000 (20:02 +0100)]
drop: Ensure all relevant formats are available
1. GdkDrop does deserialization, so add the deserialize formats
2. If the drop is local, we can copy straight from the drag, so we can
also copy all its formats. This fixes cases where the backend would
drop formats it doesn't support.
Timm Bäder [Sat, 15 Feb 2020 10:19:25 +0000 (11:19 +0100)]
calendar: Emit {next,prev}-{month,year} signals
Fixes #833
Timm Bäder [Sat, 15 Feb 2020 10:10:19 +0000 (11:10 +0100)]
widget: Use get_css_name() in get_property()
Instead of reimplementing it there.
Timm Bäder [Sat, 15 Feb 2020 09:45:33 +0000 (10:45 +0100)]
Adwaita: Add focus outlines back to scale troughs
Fixes #189
Timm Bäder [Sat, 15 Feb 2020 09:25:41 +0000 (10:25 +0100)]
coloreditor: Scale h value to 360
Fixes #1321
Timm Bäder [Sat, 15 Feb 2020 09:14:13 +0000 (10:14 +0100)]
range: Avoid rounding errors when allocating highlight
Fixes #2438
Timm Bäder [Sat, 15 Feb 2020 08:55:27 +0000 (09:55 +0100)]
widget: Add css-classes property
Mirroring the values added and removed via {add,remove}_css_class().
Timm Bäder [Fri, 14 Feb 2020 17:25:01 +0000 (18:25 +0100)]
infobar: Remove _get_{action,content}_area()
Accessors like these are weird to have and we can add widgets to the
content area via gtk_container_add() as well as add widgets to the
action area via gtk_info_bar_add_action_widget().
Timm Bäder [Fri, 14 Feb 2020 17:22:59 +0000 (18:22 +0100)]
Remove gtk_info_bar_get_content_area() uses
We can just add() to the info bar directly.
Timm Bäder [Fri, 14 Feb 2020 17:14:33 +0000 (18:14 +0100)]
testinfobar: Stop using gtk_info_bar_get_content_area()
We have an easier way of adding widgets to the content area of an
infobar: Just gtk_container_add() them like usual.
Timm Bäder [Fri, 14 Feb 2020 17:06:39 +0000 (18:06 +0100)]
infobar: Don't store close button visibility separately
We can already set and query that value via
gtk_widget_{get,set}_visible() on the close button.
Timm Bäder [Fri, 14 Feb 2020 17:00:48 +0000 (18:00 +0100)]
actionbar: Use a bin layout
Timm Bäder [Thu, 13 Feb 2020 17:40:20 +0000 (18:40 +0100)]
calendar: Add style class to today's label
Add the .today style class to the label indicating the current day.
Fixes #230
Timm Bäder [Thu, 13 Feb 2020 16:53:42 +0000 (17:53 +0100)]
calendar: Document style classes
Fixes #790
Matthias Clasen [Fri, 14 Feb 2020 21:46:43 +0000 (16:46 -0500)]
events: Make proximity and scroll events have tools
The Wayland backend tries to set device tools on these
events, and it was just an oversight that they don't
carry them.
Benjamin Otte [Fri, 14 Feb 2020 20:42:11 +0000 (20:42 +0000)]
Merge branch 'wip/otte/for-master' into 'master'
Drop GTK_WINDOW_POPUP
See merge request GNOME/gtk!1437
Matthias Clasen [Mon, 30 Dec 2019 06:24:05 +0000 (01:24 -0500)]
Drop gdk_surface_new_temp
GTK is not using this API anymore, and we want
to consolidate our surface types to just toplevels
and popups.
Matthias Clasen [Mon, 30 Dec 2019 06:23:26 +0000 (01:23 -0500)]
testsuite: Stop using gdk_surface_new_temp
We can just use regular toplevels here.
Benjamin Otte [Fri, 14 Feb 2020 20:13:42 +0000 (21:13 +0100)]
window: Remove GtkWindowType and window->type
And remove code that was making decisions on the type and just use
the part for toplevels.
Benjamin Otte [Fri, 14 Feb 2020 20:15:45 +0000 (21:15 +0100)]
testsuite: Use GtkTextDirection instead of GtkWindowType
GtkWindowType is aout to be dropped, so use another enum for the enum
tests - one that is likely to survive for a long time.
Benjamin Otte [Fri, 14 Feb 2020 19:57:53 +0000 (20:57 +0100)]
textview: Fix docs typo
Benjamin Otte [Fri, 14 Feb 2020 19:55:36 +0000 (20:55 +0100)]
window: Remove type argument from gtk_window_new()
Benjamin Otte [Fri, 14 Feb 2020 19:32:10 +0000 (20:32 +0100)]
testsuite: Replace popups with toplevels
The tests do not depend on the window being a popup.
Benjamin Otte [Fri, 14 Feb 2020 18:32:50 +0000 (19:32 +0100)]
builder: Use different construct-only property
The window type is going away, so use the css name instead.
Benjamin Otte [Fri, 14 Feb 2020 19:25:00 +0000 (20:25 +0100)]
widget: Add gtk_widget_get_css_name() API
Benjamin Otte [Fri, 14 Feb 2020 18:48:58 +0000 (19:48 +0100)]
testsuite: Remove popup property from simplify tools
I'm not even sure a popup GtkAssistant should be a thing...
Benjamin Otte [Fri, 14 Feb 2020 18:27:17 +0000 (19:27 +0100)]
testsuite: Turn all CSS test ui files into regular windows
Use undecorated windows instead of popups.
Benjamin Otte [Fri, 14 Feb 2020 18:25:23 +0000 (19:25 +0100)]
testsuite: Make a11y tests use regular windows
Benjamin Otte [Fri, 14 Feb 2020 17:12:17 +0000 (17:12 +0000)]
Merge branch 'wip/otte/for-master' into 'master'
reftests: Change popup windows to non-decorated windows
See merge request GNOME/gtk!1435
Benjamin Otte [Fri, 14 Feb 2020 16:54:38 +0000 (17:54 +0100)]
reftests: Change popup windows to non-decorated windows
This allows getting rid of popup windows.
Matthias Clasen [Fri, 14 Feb 2020 13:47:36 +0000 (08:47 -0500)]
Merge branch 'zhaoqiang/gtk-To_avoid_compiler_warning'
Matthias Clasen [Fri, 14 Feb 2020 13:19:42 +0000 (13:19 +0000)]
Merge branch 'master-subtract-base-size' into 'master'
gdk: Subtract base size when checking aspect ratio
See merge request GNOME/gtk!1331
Mohammed Sadiq [Fri, 14 Feb 2020 02:39:21 +0000 (02:39 +0000)]
Merge branch 'wip/otte/for-master' into 'master'
slicelistmodel: Fix two wrong computations
See merge request GNOME/gtk!1433
Benjamin Otte [Fri, 14 Feb 2020 02:13:49 +0000 (03:13 +0100)]
slicelistmodel: Fix two wrong computations
Both of those are thinkos during math.
Found by Mohammed Sadiq.
Testcases triggering both have been added.
Matthias Clasen [Fri, 14 Feb 2020 02:14:01 +0000 (21:14 -0500)]
Force-create style contexts in realize
This is necessary as long as style contexts are
required for proper css change tracking.
Fixes #2435
Emmanuele Bassi [Thu, 13 Feb 2020 19:53:33 +0000 (19:53 +0000)]
Merge branch 'master' into 'master'
Fixed OpenGL extension detection for extensions promoted to OpenGL core.
Closes #2428
See merge request GNOME/gtk!1424
David Hogan [Wed, 12 Feb 2020 20:55:59 +0000 (07:55 +1100)]
Fix detection of OpenGL 3.3 core GL_ARB_timer_query.
Some systems (notably macOS) will not allow enumeration of an extension that has been promoted to core OpenGL for context in use. This change assumes that GL_ARB_timer_query is available on OpenGL 3.3+.
I could not find definitive information on whether GL_ARB_debug_output or GL_KHR_debug have been added to core. Other extensions in use were addressed by https://gitlab.gnome.org/GNOME/gtk/merge_requests/1422 .
David Hogan [Wed, 12 Feb 2020 19:52:24 +0000 (06:52 +1100)]
Fixed OpenGL extension detection for extensions promoted to OpenGL core.
For a given OpenGL context, macOS in particular does not support enumeration / detection of OpenGL features that have been promoted to core OpenGL functionality. It is possible other drivers are the same. This change assumes support for GL_ARB_texture_non_power_of_two with OpenGL 2.0+, GL_ARB_texture_rectangle with OpenGL 3.1+ and GL_EXT_framebuffer_blit with OpenGL 3.0+. I failed to find definitive information on whether GL_GREMEDY_frame_terminator has been promoted to OpenGL core, or whether GL_ANGLE_framebuffer_blit or GL_EXT_unpack_subimage have been promoted to core in OpenGL ES. This change results in a significant GtkGLArea performance boost on macOS.
Closes #2428
Emmanuele Bassi [Thu, 13 Feb 2020 18:10:29 +0000 (18:10 +0000)]
Merge branch 'ci-flatpak' into 'master'
CI pipeline changes for Flatpak jobs
See merge request GNOME/gtk!1429
Emmanuele Bassi [Thu, 13 Feb 2020 17:10:19 +0000 (17:10 +0000)]
ci: Remove G_MESSAGES_DEBUG
We don't need all the debugging messages.
Emmanuele Bassi [Thu, 13 Feb 2020 17:09:35 +0000 (17:09 +0000)]
ci: Allow flatpak jobs to fail
We have more accurate CI jobs, now; the Flatpak jobs are nice to have.
Matthias Clasen [Thu, 13 Feb 2020 16:38:41 +0000 (16:38 +0000)]
Merge branch 'gi-fixes' into 'master'
Various fixes for documentation and introspectable API
See merge request GNOME/gtk!1427
Matthias Clasen [Thu, 13 Feb 2020 16:21:15 +0000 (11:21 -0500)]
Make release builds mandatory for ci
The tests are now passing in release builds, lets keep
it that way.
Matthias Clasen [Thu, 13 Feb 2020 15:56:26 +0000 (10:56 -0500)]
testsuite: Handle icontheme test better
Skip just the failing tests in release builds.
Matthias Clasen [Thu, 13 Feb 2020 15:42:21 +0000 (10:42 -0500)]
gsk: Fix the compiler warning differently
Emmanuele Bassi [Thu, 13 Feb 2020 15:04:04 +0000 (15:04 +0000)]
Merge branch 'report-fixes' into 'master'
Fixes for the CI test reports
See merge request GNOME/gtk!1426
Emmanuele Bassi [Thu, 13 Feb 2020 14:45:08 +0000 (14:45 +0000)]
ci: Use per-suite anchors
Anchors are global, so they need to be namespaced.
Emmanuele Bassi [Thu, 13 Feb 2020 14:26:40 +0000 (14:26 +0000)]
ci: Rearrange the results in the HTML report
Move the failures up top, so they stand out.
Emmanuele Bassi [Thu, 13 Feb 2020 14:23:59 +0000 (14:23 +0000)]
ci: Fix the HTML anchor in the report
Emmanuele Bassi [Thu, 13 Feb 2020 13:56:33 +0000 (13:56 +0000)]
ci: Use result instead of exit code in the JUnit report
We have a result code coming from Meson which is more accurate than just
looking at the exit code of the unit.
Emmanuele Bassi [Thu, 13 Feb 2020 13:54:22 +0000 (13:54 +0000)]
ci: Unexpected passes are failures
List them as such in our reports.
Emmanuele Bassi [Thu, 13 Feb 2020 13:54:02 +0000 (13:54 +0000)]
ci: Put the branch name in the HTML header
Emmanuele Bassi [Thu, 13 Feb 2020 13:52:57 +0000 (13:52 +0000)]
ci: Move HTML report meta from header to article
Makes the bar smaller.
Emmanuele Bassi [Thu, 13 Feb 2020 14:04:41 +0000 (14:04 +0000)]
ci: Re-enable ccache
Emmanuele Bassi [Tue, 11 Feb 2020 17:34:09 +0000 (17:34 +0000)]
Remove gtk_style_context_get_parent()
The function was declared and mentioned in the documentation, but it has
been removed in commit
416182a20d062d5865916f86909354ec85d00dd1.
Emmanuele Bassi [Tue, 11 Feb 2020 17:29:56 +0000 (17:29 +0000)]
gi: Skip gtk_custom_layout_new()
The whole GtkCustomLayout class is mostly a C convenience API, and
there's no reason why high level languages should use it.
Emmanuele Bassi [Tue, 11 Feb 2020 17:28:18 +0000 (17:28 +0000)]
Fix the function name in the gtk-doc stanza
The documentation is still referring to the old function's name.
Emmanuele Bassi [Tue, 11 Feb 2020 17:26:51 +0000 (17:26 +0000)]
Match argument name between declaration and definition
Otherwise the documentation and the introspection data will complain.
Emmanuele Bassi [Tue, 11 Feb 2020 17:25:44 +0000 (17:25 +0000)]
docs: Match the argument name with its declaration
Emmanuele Bassi [Tue, 11 Feb 2020 17:24:01 +0000 (17:24 +0000)]
Add a notify function to GdkContentProvider
The callback-based content providers need a GDestroyNotify function to
free the data passed to them on construction, otherwise they are going
to leak.
Matthias Clasen [Thu, 13 Feb 2020 14:39:27 +0000 (09:39 -0500)]
Remove border-half-pixel reftest from xfail
It passes both locally and on ci now.
Matthias Clasen [Thu, 13 Feb 2020 13:43:59 +0000 (13:43 +0000)]
Merge branch 'wip/otte/no-clip-on-draw' into 'master'
Various fixes to rendernode drawing with Cairo
See merge request GNOME/gtk!1425
Benjamin Otte [Wed, 12 Feb 2020 22:45:51 +0000 (23:45 +0100)]
gdk: Remove gdk_cairo_get_clip_rectangle()
The function is fundamentally broken for unbounded surfaces.
If a surface is unbounded, we cannot represent this as a
cairo_rectangle_int_t, and using the return value doesn't work because
it's already used for something else.
In GTK3, unbounded surfaces aren't a problem, but GTK4 uses recording
surfaces.
So better remove that function before we keep using it and using it
wrong.
Benjamin Otte [Thu, 13 Feb 2020 01:48:19 +0000 (02:48 +0100)]
cairoblur: Get rid of gdk_cairo_get_clip_rectangle() call
It's about to be removed.
Benjamin Otte [Thu, 13 Feb 2020 00:53:12 +0000 (01:53 +0100)]
gsk: Clip shadow node before push_group()
We want to be sure to push a group that's as small as possible, so we
clip to the child's bounds, because that's the smallest we can go.
Benjamin Otte [Thu, 13 Feb 2020 00:48:03 +0000 (01:48 +0100)]
gsk: Add a utility function for rectangles
... and use it.
Benjamin Otte [Wed, 12 Feb 2020 23:14:29 +0000 (00:14 +0100)]
cairoblur: Move the check for early exit
That means we only have one place where we check all kinds of early
exits.
Benjamin Otte [Wed, 12 Feb 2020 17:44:11 +0000 (18:44 +0100)]
rendernode: Avoid rounding errors
Compute the pattern matrix directly instead of transforming the cairo_t.
This ensures that when node_size / texture_size is some obscure floating
point value, we don't get rounding issues from scaling by it once we
draw the texture_size rectangle.
I have no actual failure where this comes in handy, but I had written
the code anyway, so decided to keep it.
Benjamin Otte [Thu, 13 Feb 2020 04:23:31 +0000 (05:23 +0100)]
testsuite: Add tests for rounded rect code
... including the bug that was fixed in the parent commit.
Benjamin Otte [Thu, 13 Feb 2020 06:33:18 +0000 (07:33 +0100)]
roundedrect: Fix inlining of graphene functions
graphene treats equality for contains() operations as always matching,
so do the same thing.
This is because unlike integer math, floating point cannot do the "as
close as possible to the point, but not reaching it" operation that
integer does by just subtracting 1.
Benjamin Otte [Thu, 13 Feb 2020 04:21:49 +0000 (05:21 +0100)]
roundedrect: Fix gsk_rounded_rect_intersects_rect()
The previous code would return FALSE for
gsk_rounded_rect_intersects_rect (&rounded, &rounded.bounds);
if rounded was indeed rounded.
Benjamin Otte [Wed, 12 Feb 2020 22:44:09 +0000 (23:44 +0100)]
testsuite: Don't use gdk_cairo_get_clip_rectangle()
I want to remove it.
Benjamin Otte [Thu, 13 Feb 2020 02:23:51 +0000 (03:23 +0100)]
testsuite: Don't destroy surfaces that are still used
Coercing the surfaces must not unref the old surface, because the old
surface is going to be saved to a file.
Benjamin Otte [Thu, 13 Feb 2020 05:14:05 +0000 (06:14 +0100)]
testsuite: Remove accidentally checked in file
This file should go in the listview branch I guess.
Matthias Clasen [Thu, 13 Feb 2020 03:45:24 +0000 (22:45 -0500)]
Fix flickery hover
Commit
47c44644b109e0 was a bit overzealous in fixing
compiler warnings. We still need to call collect_textures,
even if we don't need the number that it returns.
Matthias Clasen [Wed, 12 Feb 2020 23:44:38 +0000 (23:44 +0000)]
Merge branch 'wip/baedert/cairo-paint' into 'master'
Remove cairo_clip() when drawing render nodes
Closes #2431
See merge request GNOME/gtk!1418
Matthias Clasen [Wed, 12 Feb 2020 23:24:59 +0000 (18:24 -0500)]
Remove unused signal enum values
GtkWidget lost even more signals, so we don't need
these enum values anymore.
Matthias Clasen [Wed, 12 Feb 2020 22:58:41 +0000 (17:58 -0500)]
popovermenu: Avoid an uninitialized variable
Pointed out by Timm/clang.
Fixes https://gitlab.gnome.org/GNOME/gtk/issues/2434
Matthias Clasen [Wed, 12 Feb 2020 22:35:58 +0000 (22:35 +0000)]
Merge branch 'ci-pages' into 'master'
Rename the SCSS files for our themes
Closes #2423
See merge request GNOME/gtk!1423
Emmanuele Bassi [Wed, 12 Feb 2020 20:18:27 +0000 (20:18 +0000)]
Rename the SCSS files for our themes
It seems that Meson's gnome.compile_resources() cannot deal with two
files with the same name under different directories, which breaks the
build parallelism because the GResource file ends up not depending on
either the Adwaita or the HighContrast gtk-contained.css file.
This commit only changes the on-disk names of the Adwaita and
HighContrast SCSS files, and the corresponding generated CSS files; the
files in the GResource are going to be aliased to the old file names, to
minimise the breakage. We might want to change the theme entry points at
some later date, if we decide to commit to this naming scheme.
Fixes: #2423
See Meson bug: https://github.com/mesonbuild/meson/issues/6615
Matthias Clasen [Wed, 12 Feb 2020 19:23:01 +0000 (14:23 -0500)]
Fix the Emoji chooser finalize
If the Emoji chooser is finalized before the idle
has run, it would spew criticals, breaking some tests.
Avoid that.
Georges Basile Stavracas Neto [Wed, 12 Feb 2020 18:56:19 +0000 (18:56 +0000)]
Merge branch 'gbsneto/fix-emojichooser-header' into 'master'
build: Install gtkemojichooser.h
See merge request GNOME/gtk!1420
Georges Basile Stavracas Neto [Wed, 12 Feb 2020 18:41:49 +0000 (15:41 -0300)]
build: Install gtkemojichooser.h
It was made public at
ef7172dc1ee86a, but the header file
wasn't added to the public headers list.
Add the header file to the list.
Emmanuele Bassi [Wed, 12 Feb 2020 18:38:39 +0000 (18:38 +0000)]
Merge branch 'ci-pages' into 'master'
Small CI pipeline fixes
See merge request GNOME/gtk!1419